Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BatchGetItem paginated request data format. #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anthony-ffs
Copy link

This fixes the format of paginated BatchGetItem request using Table.getItems.

Without this change, the first request would succeed, but subsequent paginated requests would fail with MissingRequiredParameter: Missing required key 'RequestItems' in params. This is because the requested keys were sent as the request, rather than being placed on request.RequestItems.

Note that a large number of items must be requested in order for BatchGetItem requests to be paginated. Even with 5000 items requested DynamoDB would sometimes return them all in one response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant