Changed the coverage updates from active to visible #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanluker
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working in certain scenarios such as a split-view layout coverage for a file wasn’t displaying or updating if you switched to another file without actually focusing on the coverage file. For example, if one pane shows the coverage while another pane, which is in focus, controls which file is displayed in the first pane, the coverage pane would fail to refresh properly.
This pull request fixes that issue by changing the
listenToEditorEventslistener fromonDidChangeActiveTextEditortoonDidChangeVisibleTextEditors. As a result, coverage now updates correctly even when the file isn’t the active editor.