-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add an option to output secrets in armor #276
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; might want to augment the docs with an example;
might be good to articulate that the benefit to this is you'll store non-binary files in Git
I think a benefit is Git's packfile format handles text better than binary?
(git diff is also a little easier to use)
It would be nice if one could also enable armoring on a global level, or are there any downsides when doing this with all secrets? 🤔 |
@fzakaria, I made changes based on your suggestions. Let me know if I should change anything else, or if I should reword the doc edits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🎆 the test is sweet too.
Looks good to me; I'm not a maintainer though.
Let's see what @ryantm thinks.
This solves #269.
Summary: Age implementations support an
--armor
flag to output encrypted secrets in a PEM format that is human readable. This is useful for storing secrets in git as it makes diffs easier to view. This PR adds the ability to configure this option within thesecrets.nix
file as such: