Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback behavior to editor #284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JeremiahSecrist
Copy link

Currently if the editor is improperly set a user will run into an error and it will fail to run. Most times users have an editor on their system but could feasibly improperly configure the editor. This simply checks if a program exists including the first editor that works as the editor.

@n8henrie
Copy link
Collaborator

I worry that this is a little too opinionated; if a user doesn't have EDITOR set, I think failing seems reasonable.

Most nix users will be familiar with EDITOR and how to configure and override its value. Some very novice users may not, but I don't think dropping them into vi (as opposed to nano, which you have lower on the list) is going to go over well! (Cue the "how to exit vim" jokes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants