Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated/removed Dir.exists? method for Ruby 3.2 compatibility #26

Merged

Conversation

owst
Copy link
Contributor

@owst owst commented Jan 13, 2024

Removed in Ruby 3.2:
https://rubyreferences.github.io/rubychanges/3.2.html#removals

I removed the test method stub that hides the removal causing a false-positive test pass on Ruby 3.2

@owst
Copy link
Contributor Author

owst commented Jan 17, 2024

Hi @JorgeGarciaxyz - I see you've merged some PRs to this repo recently - hopefully this one is not controversial and could be merged and released? Thanks!

@JorgeGarciaxyz
Copy link
Collaborator

@owst sure thing, thanks for the help!

@JorgeGarciaxyz JorgeGarciaxyz merged commit 0fe8052 into ryanwood:master Jan 22, 2024
1 check failed
@owst
Copy link
Contributor Author

owst commented Jan 23, 2024

Thanks @JorgeGarciaxyz 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants