Fixed to be compatible with latest gossip API #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed error with NewManager call
rynorris
requested changes
Nov 2, 2016
| "time" | ||
|
|
||
| "gossip-demo/demo" |
There was a problem hiding this comment.
Should use the full import path here github.com/discoviking/gossip-demo/demo. Otherwise it doesn't compile when downloaded with go get as is standard.
|
|
||
| func main() { | ||
| var doCall = 0 | ||
| flag.IntVar(&doCall, "call",0, "do a test call") |
There was a problem hiding this comment.
Can we change this to be two flag.Bools called "-server" and "-client", or "-caller" and "-callee"? I think that would be a bit clearer.
|
|
||
| In another shell window, run "go run main.go -call 1" to do a test call | ||
| */ | ||
|
|
There was a problem hiding this comment.
To match style can we change this to be // style comments, and remove the newline between the comment and the function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that while trying to run the gossip-demo I also encountered some nil errors in the latest master version of gossip. I forked it into attesaarela/gossip and made some fixes and seems to run with that version. Also made a pull request on that fork of gossip.