Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support different formats for append #105

Merged
merged 7 commits into from
Jan 3, 2025
Merged

feat: Support different formats for append #105

merged 7 commits into from
Jan 3, 2025

Conversation

vrongmeal
Copy link
Member

Context: #44

@vrongmeal
feat: Support different formats for append
8f0ab75 
Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal
json
84350e3 
Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal
read output
437d4c9 
Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal marked this pull request as ready for review December 30, 2024 15:41
@vrongmeal vrongmeal requested a review from a team as a code owner December 30, 2024 15:41
@vrongmeal
Copy link
Member Author

vrongmeal commented Dec 30, 2024 •
edited
Loading

I also want to do a Hex version for both.

[EDIT] Pushed json-binsafe (base64 version)

shikhar
shikhar reviewed Jan 2, 2025
View reviewed changes
src/formats.rs Show resolved Hide resolved
shikhar
shikhar reviewed Jan 2, 2025
View reviewed changes
src/formats.rs Show resolved Hide resolved
shikhar
shikhar reviewed Jan 2, 2025
View reviewed changes
src/main.rs Show resolved Hide resolved
shikhar
shikhar reviewed Jan 2, 2025
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
shikhar
shikhar reviewed Jan 2, 2025
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@vrongmeal
address comments
b83a7d0 
Signed-off-by: Vaibhav Rabber <[email protected]>
@vrongmeal vrongmeal merged commit 180421b into main Jan 3, 2025
3 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/formats branch January 3, 2025 14:53
@shikhar shikhar mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikhar shikhar shikhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrongmeal @shikhar