❌Change json library to System.Text.Json #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2quake
force-pushed
the
refactor/text-json
branch
from
653aff6
to
60602f5
Compare
s2quake
force-pushed
the
refactor/text-json
branch
from
60602f5
to
ae9d975
Compare
s2quake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newtonsoft library is a very good library. However, the inclusion of System.Text.Json in the BCL is a big plus, as it eliminates the dependency on external libraries. Personally, I'm familiar with newtonsoft, but unfortunately it's time to let it go.