Skip to content

Commit

Permalink
Update dependencies (#141)
Browse files Browse the repository at this point in the history
* Bump ini

* Bump xml2js

* Bump minimist

* Bump fs-extra@9

* Bump fs-extra@10

* Bump fs-extra@11

* Add CI

* Sync works 🤷‍♂️

* Update engines.node to v18
  • Loading branch information
fregante authored Aug 13, 2024
1 parent 41ec759 commit 14451a6
Show file tree
Hide file tree
Showing 4 changed files with 72 additions and 61 deletions.
22 changes: 22 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: CI
on:
- push
- pull_request
jobs:
test:
name: Node.js ${{ matrix.node-version }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 18
- 20
- 22
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
16 changes: 6 additions & 10 deletions lib/firefox_profile.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,15 +266,11 @@ FirefoxProfile.prototype.deleteDir = function (cb) {
process.removeListener('exit', self.onExit);
process.removeListener('SIGINT', self.onSigInt);
this.shouldDeleteOnExit(false);
fs.exists(this.profileDir, function (doesExists) {
if (!doesExists) {
cb && cb();
return;
}
fs.remove(self.profileDir, function () {
cb && cb();
});
});
if (fs.existsSync(this.profileDir)) {
fs.removeSync(this.profileDir);
}

cb && cb();
};

/**
Expand Down Expand Up @@ -610,7 +606,7 @@ FirefoxProfile.prototype._installExtension = function (addon, cb) {
}

if (tmpDir) {
await fs.remove(tmpDir);
fs.removeSync(tmpDir);
}

return addonDetails;
Expand Down
84 changes: 37 additions & 47 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,12 @@
},
"dependencies": {
"adm-zip": "~0.5.x",
"fs-extra": "~9.0.1",
"ini": "~2.0.0",
"minimist": "^1.2.5",
"xml2js": "^0.5.0"
"fs-extra": "^11.2.0",
"ini": "^4.1.3",
"minimist": "^1.2.8",
"xml2js": "^0.6.2"
},
"engines": {
"node": ">=18"
}
}

0 comments on commit 14451a6

Please sign in to comment.