-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: use relative path in utils contracts #1169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't we decide to publish 2.0.1
? why no version bump in package.json
file, and no CHANGELOG
update?
also, i was looking at the DeployOptimized
utils test contract, this file assumes there is a out-optimized
profile under foundry configuration. which might be very unlikely, thus, should we mark it as .t.sol
instead?
Will do. I missed it.
Its not looking for the profile, but for the But, instead of renaming it to |
it is not specifically for the profile, but in order to have an i’m not saying to extract it from artifacts, i’m just saying it’s very unlikely for someone to have this profile (which would generate the above directory) and actually use this file (similarly to Precompiles). thus simply rename it to
why? :)) all the other files that are not under |
made all the changes. LMK if it looks good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
* tests: use relative path in Utility contracts * docs: update changelog and bump npm version * test: use 2.0.1 in BaseScript.t.sol * test: rename DeployOptimized.sol to DeployOptimized.t.sol * docs: update changelog * docs: update changelog Co-authored-by: Andrei Vlad Birgaoanu <[email protected]> --------- Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
Closes #1168