Skip to content
This repository has been archived by the owner on Aug 12, 2019. It is now read-only.

I dockerized your app #288

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

I dockerized your app #288

wants to merge 6 commits into from

Conversation

faddat
Copy link

@faddat faddat commented Aug 14, 2015

Very needed tool, thanks for writing it!

@faddat
Copy link
Author

faddat commented Aug 14, 2015

not well enough...

Jacob Gadikian added 2 commits August 15, 2015 06:05
yet more... evil commands....
yet more... evil commands....
@@ -8,7 +8,7 @@ install-server:
composer install --no-dev

install-client:
bower install --production
bower install --production --allow-root
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why --allow-root?

@Hywan
Copy link
Member

Hywan commented Aug 15, 2015

Thanks for the PR!

@faddat
Copy link
Author

faddat commented Aug 16, 2015

Actually I am changing it to use php7.

Basically I was testing out hhvm because I had heard it was fast.

I'll have another crack at it now.

-Jake
On Aug 15, 2015 5:18 PM, "Ivan Enderlin" [email protected] wrote:

Thanks for the PR!


Reply to this email directly or view it on GitHub
#288 (comment).

@faddat
Copy link
Author

faddat commented Aug 16, 2015

Allow root because docker images build as root.
On Aug 16, 2015 10:44 AM, "Jacob Gadikian" [email protected] wrote:

Actually I am changing it to use php7.

Basically I was testing out hhvm because I had heard it was fast.

I'll have another crack at it now.

-Jake
On Aug 15, 2015 5:18 PM, "Ivan Enderlin" [email protected] wrote:

Thanks for the PR!


Reply to this email directly or view it on GitHub
#288 (comment).

@evert
Copy link
Member

evert commented Aug 17, 2015

Neither PHP7 nor HHVM are currently fully supported unfortunately. For this to be accepted it should run on PHP 5.6.

@Hywan
Copy link
Member

Hywan commented Aug 18, 2015

@evert sabre/dav does not support PHP7 yet? I thought yes since a recent release.

@faddat
Copy link
Author

faddat commented Aug 19, 2015

I'll change it up. Sorry for the delays on my end.

Thanks!

-Jake

Jacob Gadikian
E-mail: [email protected]
SKYPE: faddat
Phone/SMS: +84 167 789 6421

On Tue, Aug 18, 2015 at 12:37 PM, Ivan Enderlin [email protected]
wrote:

@evert https://github.com/evert sabre/dav does not support PHP7 yet? I
thought yes since a recent release.


Reply to this email directly or view it on GitHub
#288 (comment).

@faddat
Copy link
Author

faddat commented Aug 19, 2015

Not even sure why I went for HHVM/PHP7 the first time around. Will submit again with 5.6 :).

@evert
Copy link
Member

evert commented Aug 19, 2015

@Hywan , next major releases will support PHP 7. So vobject 4 and sabre/dav 3.1.

Easier is better.
@Hywan
Copy link
Member

Hywan commented Aug 20, 2015

@evert: Oh yes, correct, remember the discussion now. Thanks.

@evert
Copy link
Member

evert commented Oct 20, 2015

Would you have some brief instructions on how to test this on OS X? I don't have a lot of experience with docker. I'm pretty sure I have this container up and running, but I have no idea how to connect to port 80 of the container.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants