Improve keyboard handling #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagygeri97
commented
Jan 27, 2024
nagygeri97
commented
- Ensure that pressing F1-F12 doesn't type it's value
- Start and stop player with space in practice mode
- Start and stop first unsolved player in daily mode
kaelonR
reviewed
Jan 28, 2024
| @@ -379,7 +379,7 @@ document.getElementById("keyboard-cont").addEventListener("click", (e) => { | |||
| document.addEventListener("keyup", (e) => { | |||
|
|
|||
| let pressedKey = String(e.key) | |||
| let found = pressedKey.match(/[a-z]/gi) | |||
| let found = pressedKey.match(/^[a-z]$/gi) | |||
There was a problem hiding this comment.
I'm wondering if this is the best way to check this though. Regex are relatively costly and slow for something like this, wouldn't it be more efficient just check that the input is within the range a to z, which causes JS to compare the ascii key code? i.e. pressedKey >= 'a' && pressedKey <= 'z'.
There was a problem hiding this comment.
no, not really. regex isnt that costly. if we really needed to change it than something like
pressedKey.toUpperCase() != char.toLowerCase() || pressedKey.codePointAt(0) > 127
nagygeri97
force-pushed
the
key-handling-improvements
branch
from
ef60d89 to
fc861bb
Compare
* Ensure that pressing F1-F12 doesn't type it's value * Start and stop player with space in practice, spelloff and youtube modes * Start and stop first unsolved player with space in daily mode
nagygeri97
force-pushed
the
key-handling-improvements
branch
from
fc861bb to
5928baa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.