Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Keystone #1911

Merged
merged 28 commits into from
Jun 23, 2023
Merged

Integrate Keystone #1911

merged 28 commits into from
Jun 23, 2023

Conversation

zhiying-fan
Copy link
Contributor

Description

This PR include two parts of work:

  1. Add basic support for connect Keystone Wallet and get extended public key from Keystone Wallet.
  2. Sign transaction using Keystone.

Changes

For adding owner key

  • Add OwnerInfoKeystoneFragment to start the QR code scanner.
  • Add KeystoneOwnerSelectionFragment to show public keys.
  • Add PublicAddressDerivator to derive public keys.
  • Add one more field on Owner named sourceFingerprint and migrated the database to version 8.

For signing

  • Add KeystoneRequestSignatureFragment for the UI of signing, KeystoneSignViewModel to handle the logic.
  • Support for signing message for signing modes:
    • CONFIRMATION
    • REJECTION
    • INITIATE_TRANSFER

The logic for signing other signing mode in the future is also implemented, which is included in KeystoneSignViewModel.

Dependencies

TBD

Tracking events name

@gnosis/mobile-devs

@liliya-soroka
Copy link
Member

liliya-soroka commented May 16, 2023

@liliya-soroka
Copy link
Member

@TanyaEfremova
Copy link

  1. Please review this design file for the images on screen screen_owner_keystone_info Open Figma file

@zhiying-fan
Copy link
Contributor Author

  1. Please review this design file for the images on screen screen_owner_keystone_info Open Figma file

Updated to latest, please have a look again.

@liliya-soroka
Copy link
Member

@zhiying-fan , any progress for point 2(the issue with the signing QR code) ?

@zhiying-fan
Copy link
Contributor Author

@zhiying-fan , any progress for point 2(the issue with the signing QR code) ?

@liliya-soroka I'm looking at the issue, and the new issues as well.

@elgatovital
Copy link
Contributor

@zhiying-fan could you please sign the CLA by commenting I have read the CLA Document and I hereby sign the CLA ?

@zhiying-fan
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@zhiying-fan zhiying-fan force-pushed the master branch 2 times, most recently from 97d1202 to 17c4484 Compare June 19, 2023 11:33
@elgatovital elgatovital merged commit 342eeb0 into safe-global:master Jun 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants