Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flush endpoint #1038

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Remove flush endpoint #1038

merged 1 commit into from
Jan 17, 2024

Conversation

hectorgomezv
Copy link
Member

@hectorgomezv hectorgomezv commented Jan 16, 2024

Depends on safe-global/safe-config-service#1026 (this PR should be merged after that one)

Please review safe-global/safe-config-service#1026 and safe-global/safe-config-service#1027 before.

Changes:

  • Removes the FlushModule routes module, including controllers, services, and entities.
  • Removes flush-associated classes in the domain layer.

Out of scope:
It's out of the scope of this PR to determine if the cache management classes can be simplified (e.g. by removing pattern-based invalidations). This will be tackled separately.

@hectorgomezv hectorgomezv self-assigned this Jan 16, 2024
@hectorgomezv hectorgomezv marked this pull request as ready for review January 17, 2024 08:03
@hectorgomezv hectorgomezv requested a review from a team as a code owner January 17, 2024 08:03
Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hectorgomezv hectorgomezv merged commit d585e5a into main Jan 17, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the remove-flush-endpoint branch January 17, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants