Return the total count of all chains instead of the current page count #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PooyaRaki
force-pushed
the
chainPaginationCount
branch
from
c3135b6 to
bfe75c3
Compare
rmeissner
approved these changes
Dec 16, 2024
iamacook
approved these changes
Dec 17, 2024
PooyaRaki
force-pushed
the
chainPaginationCount
branch
from
bfe75c3 to
5f6e7ad
Compare
iamacook
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the functionality to return the total count of all chains rather than limiting the count to only the current page. This ensures better visibility of the complete dataset while preserving the pagination functionality for retrieving individual records.
Changes