Remove unused FF_HOOK_EVENTS #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7555347666
💛 - Coveralls |
This was referenced Jan 16, 2024
iamacook
approved these changes
Jan 17, 2024
src/chains/tests/test_signals.py
Outdated
|
|
||
|
|
||
| @override_settings(CGW_URL="http://127.0.0.1", CGW_FLUSH_TOKEN="example-token") | ||
| class ChainNetworkHookWithFFHookEventsTestCase(TestCase): |
There was a problem hiding this comment.
Nit: let's remove "FF" from the name as we are no longer testing that (from my understanding).
There was a problem hiding this comment.
Yes, I totally agree! Changed in 3cce913
iamacook
approved these changes
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The Safe Client Gateway currently accepts two ways to invalidate cache registries:
/v2/flush/endpoint containing an invalidation pattern./v1/hooks/events/endpoint containing an event payload.The first approach was being used by the Config Service exclusively, when it is configured to do so (i.e.: when
FF_HOOK_EVENTSfeature flag is set). This PR removes the possibility of using this first approach in favor of using the/v1/hooks/events/endpoint instead.Changes:
FF_HOOK_EVENTSfrom the service configuration.signals.pyclasses for both Chains and Safe Apps, so these classes don't use the/v2/flush/endpoint anymore. (And modifies their test counterparts accordingly)flushfunction from the Safe Client Gateway client implementation.Out of scope:
CGW_FLUSH_TOKENto an alternative name. This would imply changes in other files and some coordination, so it will be tackled separately.