Add get missing metadata contracts task #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
changed the title
Pull Request Test Coverage Report for Build 12764420527Details
💛 - Coveralls |
falvaradorodriguez
approved these changes
Jan 10, 2025
| ) -> None: | ||
| contract_metadata_service = get_contract_metadata_service() | ||
| # Just try the first time, following retries should be scheduled | ||
| if await contract_metadata_service.should_attempt_download( | ||
| if skip_attemp_download or await contract_metadata_service.should_attempt_download( |
There was a problem hiding this comment.
Nitpicky: contract_metadata_service.should_attempt_download conditional can be in a separate variable. It would be more understandable in the future. The comment only affects the second part of the condition
There was a problem hiding this comment.
It is because I just want to evaluate the second part of the conditional y the first is True.
moisses89
commented
Jan 10, 2025
moisses89
force-pushed
the
periodiq_missing_contracts
branch
from
e07f147 to
dbd7bf9
Compare
falvaradorodriguez
approved these changes
Jan 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52