Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson: Remove unused build dependencies ppl and fplll #39562

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Contributor

Remove ppl and fplll as build dependencies according to #39548 (comment). ppl is now declared as runtime dependency (in pyproject.toml but no longer mentioned in meson.build). fplll is completely removed since its only used via fpylll.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 8ab64d8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@orlitzky
Copy link
Contributor

What's different about ppl, do we use it outside of pplpy?

@tobiasdiez
Copy link
Contributor Author

tobiasdiez commented Feb 28, 2025

What's different about ppl, do we use it outside of pplpy?

I'm not sure. There is something called a MixedIntegerLinearProgram with argument ppl whose name at least suggests that it might call some executable. Do you know if we directly call/access ppl or is it only via pplpy?

@tornaria
Copy link
Contributor

What's different about ppl, do we use it outside of pplpy?

I'm not sure. There is something called a MixedIntegerLinearProgram with argument ppl whose name at least suggests that it might call some executable. Do you know if we directly call/access ppl or is it only via pplpy?

I don't think there's any required executable. All that is needed at runtime is pplpy and its implied dependencies (i.e., the shared library libppl.so.14). Neither is necessary at build time.

@orlitzky
Copy link
Contributor

orlitzky commented Mar 1, 2025

PPL on Gentoo only installs two executables, /usr/bin/ppl-config and /usr/bin/ppl_pips. The first one is a pkg-config replacement, and the second doesn't turn up in grep, so I'm pretty confident that we don't use either at runtime.

For libppl, I've done a find ... xargs objdump -p on the sage install and nothing turned up. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants