Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation of discrete valuations #39612

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Improve documentation of discrete valuations #39612

wants to merge 2 commits into from

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Mar 1, 2025 •
edited
Loading

This documentation change addresses some questions that we're raised at SageDays 129.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025

Documentation preview for this PR (built with commit ca46d4e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@saraedum saraedum marked this pull request as ready for review March 1, 2025 14:56
tscrim
tscrim approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saraedum @tscrim