refactor: replace BufOnly plugin with two commands

[fidgetingbits]

While checking why BufOnly was being used, I realized we didn't need it, so this removes it.

[saidelike]

Sounds good to me. Rebasing to latest nvim-talon should fix the test on CI failure and we can merge. cc @pokey

[saidelike]

@fidgetingbits do you mind rebasing to nvim-talon so we confirm the tests pass before we merge?

[fidgetingbits]

@saidelike Not sure exactly how I closed this, I think I force pushed the wrong commit at first so it auto-closed, but now that I pushed the right commit it doesn't seem to re-open. Can you see if you can reopen it?

[fidgetingbits]

Actually I think I didn't realize you also recently force pushed already, so then force pushed back over it :/ Not sure if that is why..

[saidelike]

Actually I think I didn't realize you also recently force pushed already, so then force pushed back over it :/ Not sure if that is why..

Sorry ya it was my bad. I re-force pushed on top of it as there was an indent problem failing the pre-commit. Hopefully it is good now :)

[fidgetingbits]

I guess because this repo is defaulting to 4 space tabs, I will add a .stylua.toml file? Seems there isn't one for the repo, so my pre-commit is just picking up the defaults which is 2 spaces, and maybe single quoted strings. I forget if there was a reason we didn't add one before already?

[saidelike]

there is no stylua.toml because we use the .editorconfig for lua files too. Iiuc you had tabs (or maybe 4 spaces) but the .editorconfig requires 2 spaces. Not sure why your vscode does not automatically take that into account though.

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
indent_size = 2
indent_style = space
max_line_length = 80
trim_trailing_whitespace = true

[fidgetingbits]

Ah right. it's because I use pre-commit hooks that re-format on git commit, so they'll change things even if vscode originally followed those rules. Guess I'll check if there is a way to make pre-commit follow editorconfig or maybe just disable pre-commit for cursorless, though I happen to quite like it for certain scenarios. I think maybe stylua should also be removed from pre-commit since I think it's probably what's breaking it, but I'll file a separate issue for that.

[pokey]

Wait so is pre-commit doing different indentation on @fidgetingbits machine vs in CI?

Re the rebase fiasco above, I always advocate for a merge over a rebase when more than one person is looking at something. A rebase only makes sense before other people have seen it, or in extreme scenarios after coordinating with others

[fidgetingbits]

i recall I've always had issues with merge in PRs where I end up with the PR diff including all the unrelated upstream changes I merged in. Don't recall ever figuring out how to avoid it, so just always end up rebasing. I'll try it again next time. But ya, avoiding what just happened would be good lol.

[fidgetingbits]

And ya will have to experiment with pre-commit because I'm only using the commit hooks from this repo and apparently what I'm committing (lua at least?) fails.