really fixed margins

saiemgilani · Sep 13, 2024 · a9e94e5 · a9e94e5
1 parent cec6dfb
commit a9e94e5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/frontend/cfb/routes.js b/frontend/cfb/routes.js
@@ -513,7 +513,12 @@ function retrieveValue(dictionary, key) {
     return sub;
 }
 
-router.route('/year/:year/epa')
+router.route('/charts/team/epa')
+    .get(async function(req, res, next) {
+        return res.redirect(`/year/2024/charts/team/epa`)
+    })
+
+router.route('/year/:year/charts/team/epa')
     .get(async function(req, res, next) {
         try {
             const baseData = await retrieveLeagueData(req.params.year, "overall") 

diff --git a/frontend/public/assets/js/epa_chart.js b/frontend/public/assets/js/epa_chart.js
@@ -139,7 +139,7 @@ function generateConfig(title, teams) {
     }
 
     const margin = 0.075
-    const baseMultiplier = 0.5
+    const baseMultiplier = 0.475
     const lineMultiplier = 0.125
     const xAdjust = 0.06
 
@@ -188,7 +188,7 @@ function generateConfig(title, teams) {
                     chart.ctx.globalAlpha = 0.5;
                     chart.ctx.fillStyle = window.matchMedia('(prefers-color-scheme: dark)').matches ? '#e8e6e3' : '#525252';
                     chart.ctx.fillText("Good Offense, Good Defense", sizeWidth * (1 - margin + xAdjust), sizeHeight * margin)
-                    chart.ctx.fillText("Good Offense, Bad Defense", sizeWidth * (1 - margin + xAdjust), sizeHeight * (1 - margin - 0.01))
+                    chart.ctx.fillText("Good Offense, Bad Defense", sizeWidth * (1 - margin + xAdjust), sizeHeight * (1 - margin - 0.005))
                     chart.ctx.restore();
 
                     chart.ctx.save()
@@ -197,7 +197,7 @@ function generateConfig(title, teams) {
                     chart.ctx.globalAlpha = 0.5;
                     chart.ctx.fillStyle = window.matchMedia('(prefers-color-scheme: dark)').matches ? '#e8e6e3' : '#525252';
                     chart.ctx.fillText("Bad Offense, Good Defense", sizeWidth * (margin - 0.02), sizeHeight * margin)
-                    chart.ctx.fillText("Bad Offense, Bad Defense", sizeWidth * (margin - 0.02), sizeHeight * (1 - margin - 0.01))
+                    chart.ctx.fillText("Bad Offense, Bad Defense", sizeWidth * (margin - 0.02), sizeHeight * (1 - margin - 0.005))
                     chart.ctx.restore();
                 }
             }

diff --git a/frontend/views/partials/nav-header.ejs b/frontend/views/partials/nav-header.ejs
@@ -28,7 +28,7 @@
                     </a>
                     <ul class="dropdown-menu">
                         <h6 class="dropdown-header">Team Level</h6>
-                        <li><a class="dropdown-item" href="/cfb/teams/epa">Adj EPA/Play</a></li>
+                        <li><a class="dropdown-item" href="/charts/team/epa">Adj EPA/Play</a></li>
                     </ul>
                 </li>
                 <li class="nav-item dropdown">