Handle non-200 success codes

lib/sailthru.js

@@ -24,7 +24,7 @@
    */
 
 
-  exports.VERSION = '3.0.5';
+  exports.VERSION = '3.0.6';
 
 
   USER_AGENT = 'Sailthru API Node/JavaScript Client ' + exports.VERSION;
@@ -119,7 +119,7 @@
               that.last_rate_limit_info[parse_uri.pathname + '|' + options.method] = rate_limit_headers;
             }
 
-            if (statusCode === 200) {
+            if (statusCode >= 200 && statusCode <= 204) {
               return callback(null, json_response);
             } else {
               json_err = {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "sailthru-client",
   "description": "Node.js client for Sailthru API",
-  "version": "3.0.5",
+  "version": "3.0.6",
   "author": {
     "name": "George Liao",
     "email": "[email protected]",

test/test_sailthru.js

@@ -586,5 +586,46 @@
     });
   };
 
+  // ensure we will correctly handle 201 and 204 responses
+  exports.saveWatch = function(test) {
+    const watchData = { 
+      profile_id: '12345', 
+      watch: { 
+        interest_type: 'wishlist', 
+        query: { content_id: '67890' },
+      },
+    }
+
+    nock('https://api.sailthru.com')
+      .post(/^\/content\/watch/, function (q) {
+        var data = JSON.parse(q.json);
+        test.deepEqual(data, watchData);
+        return true;
+      })
+      .reply(201, {/* don't care about response */});
+
+    test.expect(2);
+
+    var callback = function(err, res) {
+      test.equal(err, undefined);
+      test.done();
+    };
+    SailthruClient.apiPost('content/watch', watchData, callback);
+  };
+
+  exports.deleteWatch = function(test) {
+    nock('https://api.sailthru.com')
+      .delete(/^\/content\/watch/)
+      .reply(204, {/* don't care about response */});
+
+    test.expect(1);
+
+    var callback = function(err, res) {
+      test.equal(err, undefined);
+      test.done();
+    };
+    SailthruClient.apiDelete('content/watch', {}, callback);
+  };
+
 
 }).call(this);