Revert JSON stringfy for error in OTEL transport

saleor · Sep 24, 2024 · 5f954ed · 5f954ed
1 parent 93969b2
commit 5f954ed
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 13 deletions.
diff --git a/.changeset/thick-poets-invite.md b/.changeset/thick-poets-invite.md
diff --git a/packages/logger/.eslintrc b/packages/logger/.eslintrc
diff --git a/packages/logger/.eslintrc.cjs b/packages/logger/.eslintrc.cjs
@@ -0,0 +1,8 @@
+module.exports = {
+  root: true,
+  extends: ["saleor"],
+  parserOptions: {
+    project: "tsconfig.json",
+    tsconfigRootDir: __dirname,
+  },
+};
diff --git a/packages/logger/src/logger-otel-transport.ts b/packages/logger/src/logger-otel-transport.ts
@@ -46,9 +46,17 @@ export const attachLoggerOtelTransport = (
      * Try to serialize Error. Modern-errors has plugin to serialize
      * https://github.com/ehmicky/modern-errors-serialize
      *
+     * It add "serialize" method that converts class to plain object, working for OTEL.
+     *
+     * This is not perfect, doesn't work for nested object. We probably need to introduce some abstraction
+     * on logger error?
      */
     try {
-      serializedAttributes.error = JSON.stringify(serializedAttributes.error);
+      const errorAttribute = serializedAttributes.error;
+      const ErrorConstructor = errorAttribute["constructor"];
+
+      // @ts-expect-error - ErrorConstructor is a class that could have serialize method. If not, safely throw and ignore
+      serializedAttributes.error = ErrorConstructor.serialize(serializedAttributes.error);
       // @ts-expect-error - Additional mapping for Datadog
       serializedAttributes.error.type = serializedAttributes.error.name;
     } catch (e) {}