Add OTEL to taxes app #1164
Merged
Add OTEL to taxes app #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🦋 Changeset detectedLatest commit: 128c24c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@saleor/delivery-engineering-js fyi |
peelar
approved these changes
Jan 11, 2024
apps/taxes/.env.example
Outdated
| APP_API_BASE_URL=_PATTERN= |
There was a problem hiding this comment.
is everything okay with this var?
witoszekdev
approved these changes
Jan 11, 2024
| argumentsArrayName: "payload", | ||
| minLevel: parseInt(process.env.NEW_APP_LOG_LEVEL ?? "3", 10), | ||
| }); | ||
| logger.settings.maskValuesOfKeys = ["metadata", "username", "password", "apiKey"]; |
There was a problem hiding this comment.
question: If this logger is imported from a shared package, won't that cause interference that we change a global value?
There was a problem hiding this comment.
each app is built separately so this code is never executed for other apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
Related issues
Checklist