Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gtin attribute to the google feed app #1186

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

Droniu
Copy link
Member

@Droniu Droniu commented Jan 31, 2024

Scope of the PR

This PR makes it possible to link Saleor attribute to GTIN attribute in Google Feed app.
image

Related issues

Checklist

@Droniu Droniu requested a review from a team January 31, 2024 19:19
Copy link

changeset-bot bot commented Jan 31, 2024

🦋 Changeset detected

Latest commit: 486dde1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
products-feed Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Comments Updated (UTC)
saleor-app-cms ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-crm ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-data-importer ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-emails-and-messages ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-invoices ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-klaviyo ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-products-feed ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-search ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-segment ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-slack ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am
saleor-app-taxes ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:52am

Copy link
Member

@poulch poulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, gr8 job 💪🏻

Copy link
Member

@krzysztofzuraw krzysztofzuraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two comments:

  1. Please add changeset 😄
  2. Do you have ticket or give information why this change is needed?

@krzysztofwolski
Copy link
Member

I'm testing PR on my instance ⏳

@krzysztofwolski
Copy link
Member

What can I say? Huge success.

image image
  • ✅ Assigning GTIN attr is optional
  • ✅ When not assigned, attribute is not added to the feed
  • ✅ When assigned, attribute is properly added to the feed

@Droniu Droniu merged commit 4ef6539 into main Feb 1, 2024
19 checks passed
@Droniu Droniu deleted the merx-7-add-gtin-attribute-to-the-google-feed branch February 1, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants