Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recreate-webhooks feature #1529

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Remove recreate-webhooks feature #1529

merged 8 commits into from
Aug 21, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Aug 20, 2024

Scope of the PR

We want to remove the webhooks recreate feature because it might cause problems with disabling webhooks for our clients in some conditions.
This feature has been replaced by a migration script running on each new deploy.

Related issues

Checklist

@poulch poulch requested a review from a team as a code owner August 20, 2024 11:39
@poulch poulch requested review from a team and andrzejewsky August 20, 2024 11:39
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
saleor-app-avatax ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 2:09pm
saleor-app-cms ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 2:09pm
saleor-app-data-importer ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 2:09pm
saleor-app-klaviyo ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 2:09pm
saleor-app-products-feed ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 2:09pm
saleor-app-search ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 2:09pm
saleor-app-smtp ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 2:09pm

Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: b17654f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
search Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – saleor-app-smtp August 20, 2024 11:44 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-data-importer August 20, 2024 11:44 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-cms August 20, 2024 11:44 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-avatax August 20, 2024 11:44 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-products-feed August 20, 2024 11:44 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-klaviyo August 20, 2024 11:44 Inactive
.changeset/dry-swans-pump.md Outdated Show resolved Hide resolved
@poulch poulch requested a review from andrzejewsky August 20, 2024 12:20
Cloud11PL
Cloud11PL previously approved these changes Aug 20, 2024
Copy link
Member

@Cloud11PL Cloud11PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would suggest writing a short description for this PR so that it's explained why this change is needed.

andrzejewsky
andrzejewsky previously approved these changes Aug 20, 2024
@poulch poulch dismissed stale reviews from andrzejewsky and Cloud11PL via c3b4877 August 20, 2024 14:03
.changeset/dry-swans-pump.md Outdated Show resolved Hide resolved
.changeset/dry-swans-pump.md Outdated Show resolved Hide resolved
andrzejewsky
andrzejewsky previously approved these changes Aug 20, 2024
@poulch poulch merged commit 3be6fa1 into main Aug 21, 2024
17 checks passed
@poulch poulch deleted the merx-838-remove-recreate branch August 21, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants