Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /register issue with ALLOWED_DOMAIN_URL env variable #1694

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

krzysztofzuraw
Copy link
Member

Scope of the PR

Removed regex escape for ALLOWED_DOMAINS_URL env variable from register handler. It isn't user input and escaping regex was causing problem with apps installation.

Related issues

Checklist

@krzysztofzuraw krzysztofzuraw requested review from a team as code owners January 16, 2025 11:06
@krzysztofzuraw krzysztofzuraw requested review from a team and Cloud11PL January 16, 2025 11:06
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: eca0065

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
products-feed Patch
klaviyo Patch
segment Patch
app-avatax Patch
cms-v2 Patch
search Patch
smtp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax 🛑 Canceled (Inspect) 💬 Add feedback Jan 16, 2025 11:14am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 11:14am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 11:14am
saleor-app-products-feed 🛑 Canceled (Inspect) 💬 Add feedback Jan 16, 2025 11:14am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 11:14am
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 11:14am
saleor-app-smtp 🛑 Canceled (Inspect) 💬 Add feedback Jan 16, 2025 11:14am

apps/cms-v2/src/pages/api/register.ts Dismissed Show dismissed Hide dismissed
apps/klaviyo/src/pages/api/register.ts Dismissed Show dismissed Hide dismissed
apps/products-feed/src/pages/api/register.ts Dismissed Show dismissed Hide dismissed
apps/search/src/pages/api/register.ts Dismissed Show dismissed Hide dismissed
Copy link
Contributor

Differences Found

✅ No packages or licenses were added.

Summary

Expand
License Name Package Count Packages
0BSD 1
Packages
  • tslib
CC BY-SA 4.0 1
Packages
  • @cspell/dict-en-common-misspellings
CC-BY-3.0 1
Packages
  • spdx-exceptions
GPL-3.0 1
Packages
  • store2
MIT (http://mootools.net/license.txt) 1
Packages
  • slick
Public Domain 1
Packages
  • jsonify
Python-2.0 1
Packages
  • argparse
SEE LICENSE IN LICENSE.md 1
Packages
  • lightcookie
WTFPL 1
Packages
  • opener
BlueOak-1.0.0 2
Packages
  • jackspeak
  • path-scurry
CC-BY-4.0 2
Packages
  • @saleor/macaw-ui
  • caniuse-lite
Unlicense 2
Packages
  • @sinonjs/text-encoding
  • big-integer
CC0-1.0 3
Packages
  • language-subtag-registry
  • spdx-license-ids
  • type-fest
<<missing>> 4
Packages
  • bruno
  • busboy
  • json-query
  • streamsearch
MPL-2.0 10
Packages
  • axe-core
  • eslint-config-turbo
  • eslint-plugin-turbo
  • turbo
  • turbo-darwin-64
  • turbo-darwin-arm64
  • turbo-linux-64
  • turbo-linux-arm64
  • turbo-windows-64
  • turbo-windows-arm64
BSD-2-Clause 31
Packages
  • @base2/pretty-print-object
  • @typescript-eslint/parser
  • @typescript-eslint/typescript-estree
  • @yarnpkg/esbuild-plugin-pnp
  • cheerio-select
  • css-select
  • css-what
  • damerau-levenshtein
  • domelementtype
  • domhandler
  • domutils
  • dotenv
  • dotenv-expand
  • entities
  • escodegen
  • eslint-scope
  • espree
  • esprima
  • esrecurse
  • estraverse
  • And 11 more...
BSD-3-Clause 52
Packages
  • @humanwhocodes/object-schema
  • @protobufjs/aspromise
  • @protobufjs/base64
  • @protobufjs/codegen
  • @protobufjs/eventemitter
  • @protobufjs/fetch
  • @protobufjs/float
  • @protobufjs/inquire
  • @protobufjs/path
  • @protobufjs/pool
  • @protobufjs/utf8
  • @saleor/eslint-plugin-saleor-app
  • @sentry/cli
  • @sentry/cli-darwin
  • @sentry/cli-linux-arm
  • @sentry/cli-linux-arm64
  • @sentry/cli-linux-i686
  • @sentry/cli-linux-x64
  • @sentry/cli-win32-i686
  • @sentry/cli-win32-x64
  • And 32 more...
ISC 72
Packages
  • @isaacs/cliui
  • @istanbuljs/load-nyc-config
  • @saleor/app-sdk
  • @ungap/structured-clone
  • abbrev
  • ansi-align
  • anymatch
  • aproba
  • are-we-there-yet
  • ast-types-flow
  • boolbase
  • c8
  • chownr
  • cli-width
  • cliui
  • color-support
  • concat-with-sourcemaps
  • console-control-strings
  • electron-to-chromium
  • eslint-import-resolver-typescript
  • And 52 more...
Apache-2.0 202
Packages
  • @ampproject/remapping
  • @aws-crypto/crc32
  • @aws-crypto/crc32c
  • @aws-crypto/ie11-detection
  • @aws-crypto/sha1-browser
  • @aws-crypto/sha256-browser
  • @aws-crypto/sha256-js
  • @aws-crypto/supports-web-crypto
  • @aws-crypto/util
  • @aws-sdk/abort-controller
  • @aws-sdk/chunked-blob-reader
  • @aws-sdk/client-dynamodb
  • @aws-sdk/client-s3
  • @aws-sdk/client-sso
  • @aws-sdk/client-sso-oidc
  • @aws-sdk/client-sts
  • @aws-sdk/config-resolver
  • @aws-sdk/core
  • @aws-sdk/credential-provider-env
  • @aws-sdk/credential-provider-http
  • And 182 more...
MIT 1662
Packages
  • @0no-co/graphql.web
  • @aashutoshrathi/word-wrap
  • @algolia/cache-browser-local-storage
  • @algolia/cache-common
  • @algolia/cache-in-memory
  • @algolia/client-account
  • @algolia/client-analytics
  • @algolia/client-common
  • @algolia/client-personalization
  • @algolia/client-search
  • @algolia/logger-common
  • @algolia/logger-console
  • @algolia/recommend
  • @algolia/requester-browser-xhr
  • @algolia/requester-common
  • @algolia/requester-node-http
  • @algolia/transporter
  • @ardatan/relay-compiler
  • @ardatan/sync-fetch
  • @arr/every
  • And 1642 more...

@krzysztofzuraw krzysztofzuraw merged commit 0db174a into main Jan 16, 2025
22 checks passed
@krzysztofzuraw krzysztofzuraw deleted the fix-register-issue branch January 16, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants