Cleanup Segment app #1699
Cleanup Segment app #1699
Conversation
🦋 Changeset detectedLatest commit: c872a40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
apps/segment/next.config.js
Outdated
| // dependencies of aws-sdk-client-mock | ||
| "@aws-sdk/client-s3", | ||
| "@aws-sdk/client-sns", | ||
| "@aws-sdk/client-sqs", |
There was a problem hiding this comment.
question: is this included in the production bundle? that's weird since this is aws-sdk-client-mock, right? we shouldn't worry about these packages in the first place, maybe we have some import from test file? or maybe next.js incorrectly bundles devDependencies to production bundle?
There was a problem hiding this comment.
I've removed this config entry in c872a40 (#1699)
apps/segment/next.config.js
Outdated
| @@ -23,6 +23,15 @@ const nextConfig = { | |||
| "@trpc/next", | |||
| "@saleor/apps-shared", | |||
| ], | |||
| serverComponentsExternalPackages: [ | |||
There was a problem hiding this comment.
I briefly checked docs and I'm not convinced if this affects pages router?
There was a problem hiding this comment.
I've removed this config entry in c872a40 (#1699)
vercel
bot
temporarily deployed
to
Preview – saleor-app-products-feed
Scope of the PR
Related issues
Checklist