Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restricted import rule for Sentry pkg #1700

Closed
wants to merge 2 commits into from

Conversation

krzysztofzuraw
Copy link
Member

Scope of the PR

Related issues

Checklist

@krzysztofzuraw krzysztofzuraw requested review from a team and witoszekdev January 20, 2025 14:48
Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: ddcafc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-config-saleor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 8:20am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
saleor-app-avatax ⬜️ Skipped (Inspect) 💬 Add feedback Jan 21, 2025 8:20am
saleor-app-cms ⬜️ Skipped (Inspect) 💬 Add feedback Jan 21, 2025 8:20am
saleor-app-klaviyo ⬜️ Skipped (Inspect) Jan 21, 2025 8:20am
saleor-app-products-feed ⬜️ Skipped (Inspect) 💬 Add feedback Jan 21, 2025 8:20am
saleor-app-search ⬜️ Skipped (Inspect) 💬 Add feedback Jan 21, 2025 8:20am
saleor-app-smtp ⬜️ Skipped (Inspect) 💬 Add feedback Jan 21, 2025 8:20am

Comment on lines +41 to +42
selector: "ImportDeclaration[source.value='@sentry/nextjs'] > ImportDefaultSpecifier",
message: "Use `import * as Sentry from '@sentry/nextjs';`",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add comment with docs why this rule should be used?

@krzysztofzuraw krzysztofzuraw requested a review from a team as a code owner January 21, 2025 08:18
@vercel vercel bot temporarily deployed to Preview – saleor-app-smtp January 21, 2025 08:18 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-klaviyo January 21, 2025 08:18 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-cms January 21, 2025 08:18 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-avatax January 21, 2025 08:18 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-products-feed January 21, 2025 08:18 Inactive
@vercel vercel bot temporarily deployed to Preview – saleor-app-search January 21, 2025 08:18 Inactive
@krzysztofzuraw
Copy link
Member Author

I'm closing this one - I checked and importing directly e.g captureException from Sentry works without the issue and this rule is not needed

@krzysztofzuraw krzysztofzuraw deleted the add-restricted-import branch January 21, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants