Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create ResourcePolicyDocument with internet reachable check #321

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

gruebel
Copy link
Collaborator

@gruebel gruebel commented Oct 7, 2023

What does this PR do?

  • created a new ResourcePolicyDocument class, which acts as base class for AssumeRolePolicyDocument
  • added a internet_accessible_actions property to determine, if the actions can be used by anyone (adapted version from policyuniverse)

What gif best describes this PR or how it makes you feel?

Completion checklist

  • Additions and changes have unit tests
  • The pull request has been appropriately labeled using the provided PR labels
  • GitHub actions automation is passing (make test, make lint, make security-test, make test-js)
  • If the UI contents or JavaScript files have been modified, generate a new example report:
# Generate the updated Javascript bundle
make build-js

# Generate the example report
make generate-report

@gruebel gruebel added the enhancement New feature or request label Oct 7, 2023
@gruebel gruebel merged commit d2bc55f into salesforce:master Oct 12, 2023
14 checks passed
@gruebel gruebel deleted the add-resource-policy branch October 12, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant