test(ssr-compiler): narrow which unused imports are expected (#4856)

Co-authored-by: Nolan Lawson <[email protected]>
salesforce · Nov 13, 2024 · 24fb303 · 24fb303
1 parent 2c6875c
commit 24fb303
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/packages/@lwc/ssr-compiler/src/__tests__/fixtures.spec.ts b/packages/@lwc/ssr-compiler/src/__tests__/fixtures.spec.ts
@@ -57,14 +57,18 @@ async function compileFixture({ input, dirname }: { input: string; dirname: stri
                 modules: [{ dir: modulesDir }],
             }),
         ],
-        onwarn({ message, code }) {
-            if (
-                code === 'CIRCULAR_DEPENDENCY' ||
-                // TODO [#4793]: fix unused imports
-                code === 'UNUSED_EXTERNAL_IMPORT'
-            ) {
+        onwarn({ message, code, names }) {
+            if (code === 'CIRCULAR_DEPENDENCY') {
                 return;
             }
+            // TODO [#4793]: fix unused imports
+            if (code === 'UNUSED_EXTERNAL_IMPORT') {
+                const unexpected = new Set(names);
+                const expected = ['connectContext', 'htmlEscape', 'track'];
+                expected.forEach((name) => unexpected.delete(name));
+                if (unexpected.size === 0) return;
+            }
+
             throw new Error(message);
         },
     });