fix(ssr): fix rendering of class attribute
#4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Nov 7, 2024
There was a problem hiding this comment.
I get the intention behind writing renderAttrs twice, but I figured we can just write it once using string concatenation and then share the impl for both yield and no-yield flavor. No-yield is probably going away soon anyway.
wjhsf
reviewed
Nov 12, 2024
| } | ||
| throw new Error(`Unimplemented child attr IR node type: ${value.type}`); | ||
| }) | ||
| .filter(Boolean) as EsProperty[]; |
There was a problem hiding this comment.
Suggested change
| .filter(Boolean) as EsProperty[]; | |
| .filter(<T>(v: T): v is NonNullable<T> => v) |
I thiiink this works?
There was a problem hiding this comment.
I think this is actually less clear than the previous version. It's a shame TS doesn't understand .filter(Boolean).
There was a problem hiding this comment.
Suggested change
| .filter(Boolean) as EsProperty[]; | |
| .filter(v => v is EsProperty => Boolean(v)); |
There was a problem hiding this comment.
Didn't work. I'm not going to fight TypeScript on this one
wjhsf
approved these changes
Nov 12, 2024
ekashida
approved these changes
Nov 12, 2024
nolanlawson
commented
Nov 12, 2024
| 'attribute-class/with-scoped-styles/dynamic/index.js', | ||
| 'attribute-class/with-scoped-styles/static/index.js', |
There was a problem hiding this comment.
We need to implement template class binding: salesforce/lwc-rfcs#87
…omponent.ts Co-authored-by: Will Harney <[email protected]>
…ormers/component.ts" This reverts commit 8adf666.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes a couple tests for rendering the
classattribute. We weren't correctly handling the scope token in a number of places, including:classcontains spaces, tabs, etc.I also added some more tests to handle more edge cases.
Before: 154 passed out of 199
After: 158 passed out of 203
(Two of the newly-added tests are failing due to #4802.)
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?