chore(ssr): use test options for expected failures

[cardoso]

Details

Follow up to #4816.

Uses vitest's built-in support for expected failures.

I also removed description from TestFixtureConfig since it's unused.

Does this pull request introduce a breaking change?

• 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

• 🤞 No, it does not introduce an observable change.

GUS work item

[wjhsf]

I also removed description from TestFixtureConfig since it's unused.

That's because we have too many test fixtures to add it all at once and I haven't gotten around to it yet. 😅 #4851

[cardoso]

@wjhsf totally get it!

I think the config.json should only affect how the fixture is processed by the test not the test itself. Same with ssrFiles. This couples test collection and execution which makes it difficult to reuse logic and blocks some possible perf gains.

It's not huge right now, but could be an issue in the near future. Eg:

lwc/packages/@lwc/engine-server/src/__tests__/fixtures.spec.ts

Lines 146 to 155 in 82467e3

	describe.concurrent('fixtures', () => {
	describe.concurrent('default', () => {
	testFixtures();
	});
	// Test with and without the static content optimization to ensure the fixtures are the same
	describe.concurrent('enableStaticContentOptimization=false', () => {
	testFixtures({ enableStaticContentOptimization: false });
	});
	});

Each suite adds +2s on my M1 Max.

[nolanlawson]

Wow, this is neat! TIL. 🙂 Thanks!

[nolanlawson]

/nucleus test

[nolanlawson]

/nucleus test