Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): fix rendering of spellcheck attribute #4868

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

nolanlawson
Copy link
Collaborator

Details

Does what it says on the tin.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner November 14, 2024 22:27
Copy link
Contributor

@wjhsf wjhsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to deal with draggable?

@nolanlawson
Copy link
Collaborator Author

nolanlawson commented Nov 14, 2024

In this case no because we are merely following what the template compiler currently does, which is to munge string literals for spellcheck into a boolean.

Since there's no reflection involved here, there is strictly no need to do anything with draggable unless we also want to change the template compiler (which of course has ramifications for backwards compat).

Well maybe yeah. In this case spellcheck is being treated as a prop. We may need to investigate draggable.

@nolanlawson
Copy link
Collaborator Author

Yeah I think #4864 demonstrates that we munge all spellcheck literals into pseudo-booleans (spellcheck="true"/spellcheck="false") when we should probably do the same thing for draggable since it's the same thing with the default inverted.

@nolanlawson
Copy link
Collaborator Author

I don't have the brain cells for this right now at 4pm, but filed a bug: #4870

@nolanlawson nolanlawson merged commit 7d7dea4 into master Nov 14, 2024
11 checks passed
@nolanlawson nolanlawson deleted the nolan/fix-spellcheck-ssr branch November 14, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants