Move test folders #155
Merged
Move test folders #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfdctaka
commented
Nov 12, 2024
| "composite": true | ||
| }, | ||
|
|
||
| "include": ["src"], | ||
| "include": ["src", "test", "testFixture/**/*.json"], |
There was a problem hiding this comment.
Test fixture needs to be specified in include, otherwise can't be found.
sfdctaka
requested review from
ben-zhang-at-salesforce and
haifeng-li-at-salesforce
sfdctaka
force-pushed
the
moveTestFolders
branch
from
6db4420
to
9a21671
Compare
|
The code functions as expected, but I have some concerns about the structure of the compiled code. The main goal of relocating the test folder was to prevent it from being included in the vsix package. However, after moving test to the same directory level as src, the test folder still ends up generated and included in the compiled out directory. Does this outcome go against our original intention? Is there a way to run all the tests without having them included in the |
haifeng-li-at-salesforce
approved these changes
Nov 13, 2024
maliroteh-sf
approved these changes
Nov 13, 2024
ben-zhang-at-salesforce
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moved test folders for each package. Making them sit at the level as respective
srcfolders.