generated from salesforcecli/lerna-template
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(data:export): add NUTs for big exports #1145
Open
cristiand391
wants to merge
6
commits into
main
Choose a base branch
from
cd/large-bulk-export-nut
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fb70a3b
test(data:export): add NUTs for big exports
cristiand391 123d4cf
chore: get hub username from testkit
cristiand391 7e68d89
Merge remote-tracking branch 'origin/main' into cd/large-bulk-export-nut
cristiand391 f85bf19
fix: skip last EOL from csv payload
cristiand391 a522cca
chore: refactor + handle more cases
cristiand391 c6de660
chore: remove only
cristiand391 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,16 +201,17 @@ export async function validateCsv( | |
} | ||
|
||
/** | ||
* Validate that a JSON file has X records | ||
* Validate that a JSON file has an array of records (and props) | ||
* | ||
* @param filePath JSON file to validate | ||
* @param props Array of props each record should have | ||
* @param totalqty Total amount of records in the file | ||
*/ | ||
export async function validateJson(filePath: string, totalqty: number): Promise<void> { | ||
export async function validateJson(filePath: string, props: string[], totalqty: number): Promise<void> { | ||
// check records have expected fields | ||
const fieldsRes = await exec( | ||
`jq 'map(has("Id") and has("Name") and has("Phone") and has("AnnualRevenue")) | all' ${filePath}`, | ||
{ | ||
shell: 'pwsh', | ||
} | ||
); | ||
const fieldsRes = await exec(`jq 'map(${props.map((field) => `has("${field}")`).join(' and ')}) | all' ${filePath}`, { | ||
shell: 'pwsh', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. small refactor to remove hardcoded fields in the |
||
}); | ||
expect(fieldsRes.stdout.trim()).equal('true'); | ||
|
||
// check all records were written | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query
scratchorginfo
records in our na40 hub: