Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Gemspec/DevelopmentDependencies cop [CPGM-595] #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable Gemspec/DevelopmentDependencies cop [CPGM-595] #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
760bc02
Disable Gemspec/DevelopmentDependencies cop
ric2b Feb 1, 2024
350061a
Version bump
ric2b Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# salsify_rubocop

## 1.59.1
- Disable the `Gemspec/DevelopmentDependencies` cop as it goes against our current pattern for development dependencies on gems.

## 1.59.0
- Upgrade `rubocop` to v1.59.0 to support Ruby 3.3.

Expand Down
3 changes: 3 additions & 0 deletions conf/rubocop_without_rspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ Bundler/GemComment:
- 'github'
- 'gist'

Gemspec/DevelopmentDependencies:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use EnforcedStyle: gemspec so we can enforce the pattern we use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikkessler1 I'm ok with that, unless we happen to have some gems that use Gemfile and then we're causing the opposite problem.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even then, it seems like forcing them to use our convention of using the gemspec is what we want, right?

Enabled: false

Gemspec/RequiredRubyVersion:
Exclude:
- schemas_gem/*_schemas.gemspec
Expand Down
2 changes: 1 addition & 1 deletion lib/salsify_rubocop/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module SalsifyRubocop
VERSION = '1.59.0'
VERSION = '1.59.1'
end