Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): support options as data structure #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tacerus
Copy link
Contributor

@tacerus tacerus commented Feb 15, 2024

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required) (there don't seem to be any)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Support the passing of arguments to an exported directory using a proper data structure.

Pillar / config required to test the proposed changes

nfs:
  server:
    exports:
      # new format 1
      /srv/cats:
        foo:
          - async
          - nohide
        bar: rw
      # new format 2
      /srv/dogs:
        foo: nohide
      # old format
      /srv/nfs: localhost(rw,nohide)

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Support the passing of arguments to an exported directory using
a proper data structure to facilitate a more uniform configuration
and to allow users to utilize pillar merging of hosts/options.

Signed-off-by: Georg Pfuetzenreuter <[email protected]>
@daks daks requested a review from a team March 2, 2024 17:03
Copy link
Contributor

@baby-gnu baby-gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generate proper exports file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants