Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [master] Add python 3.13 requirements files #66983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Oct 21, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dwoz dwoz requested a review from a team as a code owner October 21, 2024 20:51
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add python 3.13 requirements files [master] Add python 3.13 requirements files Oct 21, 2024
@dwoz dwoz changed the title [master] Add python 3.13 requirements files [wip] Add python 3.13 requirements files Oct 21, 2024
dmurphy18
dmurphy18 previously approved these changes Oct 21, 2024
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering about some of the dependencies, for example: cryptography does state support for Py 3.13 yet but presume it works.
Can we drop Py 3.8 given it is EOL as of beginning of this month, and will be really dead by the time this hits the streets.
Also do we still need to keep freebsd around, given we are no longer supporting it, or is it good to at least have it there for Krill etc., make his life easier.

@dwoz dwoz changed the title [wip] Add python 3.13 requirements files [wip] [master] Add python 3.13 requirements files Oct 21, 2024
@dwoz
Copy link
Contributor Author

dwoz commented Oct 21, 2024

Wondering about some of the dependencies, for example: cryptography does state support for Py 3.13 yet but presume it works. Can we drop Py 3.8 given it is EOL as of beginning of this month, and will be really dead by the time this hits the streets. Also do we still need to keep freebsd around, given we are no longer supporting it, or is it good to at least have it there for Krill etc., make his life easier.

I actually think we should drop support for anything less than 3.10 in 3008.

@dmurphy18
Copy link
Contributor

@dwoz I'd second that, dropping support for everything less than Python 3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants