-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack: extract release script to generate download info from the release doc #187
Conversation
fa22d3d
to
ef00ffa
Compare
ef00ffa
to
f41e9bc
Compare
I updated the script to fix a shellcheck error caught by the ci. Now this is not a verbatim extraction from the doc any more. |
Sorry @obnoxxx but I didn't really mean to make this a fully fledged script. It was more meant as a template someone running the release can use. |
a6cbf02
to
235f3cf
Compare
@phlogistonjohn wrote:
Understood, but I thought that having to copy and paste from the doc lacks a level of convenience that providing an actual script offers. |
@phlogistonjohn wrote:
I still think that an actual script in the repo adds more real convenience than a copy-and-paste template which is better than no automation but clumsy to use at best (IMHO). since you are opposed to having this, @phlogistonjohn), should I just go ahead and close this PR? |
I'm less opposed to it and more 🤷 on having it. if you can get someone else to +1 having it as a script I will be willing to accept it as a separate script. I was also not paying attention to this over the holidays... so don't feel my earlier silence was opposition, just neglect. |
235f3cf
to
8e710d8
Compare
@anoopcs9, github says that you requested changes but I can't see any more what it was that you requested. |
Because my previous suggestion was resolved without making any changes in the updated version. I've "unresolved" it for now. Let me know what you think. |
This extracts a script from the release process document. This script can be invoked to create the downloads section for the release notes for a given release. Signed-off-by: Michael Adam <[email protected]>
3a149ba
to
9562237
Compare
@anoopcs9 wrote:
Thanks for clarifying! I have now applied and squashed your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks.
@phlogistonjohn @obnoxxx |
It's fine. Like I said earlier: I didn't think making a full script was worth the effort... but I am ok with it if enough others wanted it. |
This extracts the script added to the the release process document as in PR #185 from the document.
This script can be invoked to create the downloads section for the release notes for a given release.