[DRAFT] Scoreboards: Canonical implementation #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninovanhooff
changed the title
|
How to convert an SDKArray to a seq? Couldn't quite figure out how to do it based on usages in sprite.nim, since userdata is used there.
In the debugger we can see that the Raw c-type (this.resource) has the correct data. Our cArray object has the correct length, but the pointers seem invalid |
ninovanhooff
commented
Oct 23, 2024
| var i = 0 | ||
| for scr in cArray: | ||
| result[i] = PDScore(resource: scr) | ||
| i *= 1 |
There was a problem hiding this comment.
No clue why this is *= and not +=. Copied from sprite.nim
|
I propose to abandon this in favor of #82 |
I'm fine with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #82.
In #82 the data returned from the playdate API is mapped to plain Nim objects, after which the C struct is free'd immediately.
The approach in this PR is more in line with the other APIs that we already offer. It wraps the c-struct and registers a destroy function to free it when the wrapper goes out of scope.
The procs for value, rank and player are unsafe to use. Users should first check whether score is nil before use.
I'm in favor of abandoning this one and continuing with #82, but I'm open to completing this one if both @Nycto and @samdze prefer it