-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recurrence Implementation #4
base: master
Are you sure you want to change the base?
Conversation
Feature/recurrence
Hi! Thanks for the PR and for the time. I'll take a look and let you know my thoughts. |
Hey. I took a brief look and looks like you're in a good direction to add recurrences support for the lib. I just think that the responsible to parse the recurrence rules from the ical content should be the role for the ical-go lib, which is currently being used. Luckily, I admin admin rights in that repo as well, so perhaps we could start abstracting some of the core stuff by moving to there. (that repo is not in a good shape, lacking some tests etc, but it's usable). What I imagine is that all the operations of parsing and calculating the recurrences (start and end time) could be done there. So that we could access the recurrences through the resource by I'll take a look this week again and let you know. |
sure - if you need any help or something is unclear drop me a mail |
Just to give you a heads up, I'm working on the |
I wrote a simple implementation to support recurring events
the most commonly used features and parameters, should work what is still missing is support for specifying lists of weekdays, months, ..
the parameter BYEASTER and BYWEEKNO and specifying a differnent weekstart day with WKST
since it would be possible to create infinite loops and out of memory errors with certain parameter sets , I also limited the maximum count of recurrences