Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequel dependency to version 4.4.0 #156

Closed
rubik opened this issue Mar 3, 2017 · 5 comments
Closed

Update sequel dependency to version 4.4.0 #156

rubik opened this issue Mar 3, 2017 · 5 comments

Comments

@rubik
Copy link

rubik commented Mar 3, 2017

In Ruby 2.4.0, the old version of sequel gives annoying warnings about Fixnum and Bignum, which in the newer version of Ruby were unified into Integer:

$ t s
/home/user/.gem/ruby/2.4.0/gems/sequel-4.0.0/lib/sequel/database/schema_generator.rb:19: warning: constant ::Fixnum is deprecated
/home/user/.gem/ruby/2.4.0/gems/sequel-4.0.0/lib/sequel/database/schema_generator.rb:19: warning: constant ::Bignum is deprecated
 Timesheet      Running     Today       Total Time
 [...]

The last version of sequel fixes these.

@dashkb
Copy link
Contributor

dashkb commented Mar 4, 2017

lol #155... @samg isn't ultra-responsive

@jostber
Copy link

jostber commented Sep 12, 2017

Sequel is regularily updated, now in version 5.0.0. What about leaving this version dependency open so timetrap works with all versions?

@jostber
Copy link

jostber commented Sep 18, 2017

Any news on this? I am packing timetrap for SlackBuild and the old sequel dependency gives a run error.

@dashkb
Copy link
Contributor

dashkb commented Sep 18, 2017

Sounds like a good idea; I'd suggest opening the PR so if @samg thinks it's a good idea he can just merge it.

@berkes
Copy link
Contributor

berkes commented Mar 9, 2020

I've updated all dependencies and fixed the issues from that in #180

@dechimp dechimp closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants