Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gem and ruby versions to latest stable versions. #180

Merged
merged 10 commits into from
Mar 17, 2020
Merged

Update gem and ruby versions to latest stable versions. #180

merged 10 commits into from
Mar 17, 2020

Conversation

berkes
Copy link
Contributor

@berkes berkes commented Mar 6, 2020

Remove EOL ruby versions from travis: don't test unsupported versions.
Add recent ruby versions: test current shipped and default versions.

berkes added 3 commits March 6, 2020 11:09
@berkes
Set travis to test against relevant ruby versions
f89af6c 
Remove EOL ruby versions from travis: don't test unsupported versions.
Add recent ruby versions: test current shipped and default versions.
@berkes
Bump bundler dependency to a recent version
e64f34c
@berkes
Ensur travis gets a bundler > 2
e75d709
@berkes berkes force-pushed the feature-ruby-versions branch from 4283072 to e75d709 Compare March 6, 2020 11:16
berkes added 2 commits March 6, 2020 12:26
@berkes
Introduce a description that is longer than the summary.
44d7b11 
This fixes a linting WARNING explaining these fields should be
different.
As per: https://guides.rubygems.org/specification-reference/#description
@berkes
Fix all open-ended dependencies with more specific dependencies
f3245d5 
This fixes warnings from the gemspec linter
@berkes berkes marked this pull request as ready for review March 9, 2020 09:16
@berkes
Copy link
Contributor Author

berkes commented Mar 9, 2020

Attempt to fix #177, #178 and #156

Before we can move forward and bump Sqlite to a recent version, the basic dependencies need to be updated to recent versions.

  • Ruby: only support alive ruby versions, no EOL rubies.
  • Rake, Bundler: recent versions.

@berkes berkes changed the title WIP: Set travis to test against relevant ruby versions Set travis to test against relevant ruby versions Mar 9, 2020
berkes added 5 commits March 9, 2020 11:23
@berkes
Add Sequel.lit() literals when we need sequel literals
efcf143
@berkes
Bump rspec to latest version.
5f03cfc
@berkes
Bump sqlite version.
19111e3 
This fixes samg#178.
@berkes
Extract the Schema and table creation from models.
caf7196 
Recent sequel did not support this, as it requires the table to exist on
parsing the Model class.
By extracting we also increase the Single Responsibility of the Models a
bit.
@berkes
Refactor rspec to use latest rspec syntax.
8e34c40 
This removes all rspec deprecation notices
@berkes berkes changed the title Set travis to test against relevant ruby versions Update gem and ruby versions to latest stable versions. Mar 9, 2020
This was referenced Mar 9, 2020
Closed
Closed
Closed
@categulario
Copy link
Collaborator

amazing job, hope it gets merged

@samg samg merged commit 199f1e6 into samg:master Mar 17, 2020
@samg
Copy link
Owner

samg commented Mar 17, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berkes @categulario @samg