Add a pull request template #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
categulario
reviewed
Sep 14, 2021
.github/pull_request_template.md
Outdated
| <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
| <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | ||
| - [ ] My code follows the code style of this project. | ||
| - [ ] My change requires a change to the documentation. |
There was a problem hiding this comment.
I suspect we can remove this one, because if the change requires modifying the documentation then they will realize that by reading the next point
There was a problem hiding this comment.
Oh, yes that makes sense 👍
With a pull request template, you can customize and standardize the information you'd like contributors to include when they open a pull requests. Inspired by: https://www.talater.com/open-source-templates/#/page/1 See this link for why we add templates: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates
fbuys
force-pushed
the
202-github-templates
branch
from
07162db to
61ae44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With a pull request template, you can customize and standardize the information you'd
like contributors to include when they open a pull requests.
Motivation and Context
Inspired by: https://www.talater.com/open-source-templates/#/page/1
See this link for why we add templates: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates
How Has This Been Tested?
We can only test this by opening up a new PR.
It does not have any affect on the gem itself.
Fixes: #202
Types of changes
Checklist: