Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract spec config to spec_helper and support files #209

Merged
merged 11 commits into from
Oct 19, 2021

Conversation

fbuys
Copy link
Contributor

@fbuys fbuys commented Oct 19, 2021

Description

  • I added a spec_helper file.
  • Moved config into the spec_helper file.
  • Added support files and moved helper functions to support files.
  • Turn spec profiling off for simpler spec output.

Motivation and Context

Part of the solution for: #206

  • We would like to split the specs into smaller spec files.
  • I believe the first step is to take all the config and helper files out of the current spec file.
  • With a simpler spec file it will be easier to extract feature and unit tests.

Much inspiration taken from here: https://lokalise.com/blog/how-to-create-a-ruby-gem-testing-suite/

How Has This Been Tested?

Automated testing.
This is a refactor so all existing specs still pass.

Screenshots (if appropriate):

image

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@dechimp dechimp merged commit 4946abd into samg:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants