Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #465 and #462 #484

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Fix #465 and #462 #484

merged 3 commits into from
Feb 7, 2025

Conversation

Tiaansu
Copy link
Contributor

@Tiaansu Tiaansu commented Sep 17, 2024 •
edited
Loading

This (hopefully) fixes the #465 and #462

@Tiaansu Tiaansu marked this pull request as draft September 17, 2024 03:54
@Tiaansu Tiaansu marked this pull request as ready for review September 17, 2024 03:55
@AmyrAhmady AmyrAhmady force-pushed the master branch 3 times, most recently from 2796929 to dd2074b Compare October 15, 2024 17:21
@AmyrAhmady
Copy link
Collaborator

Thanks for your contribution, but please remove your last commit related to CI config

@Tiaansu
Copy link
Contributor Author

Tiaansu commented Oct 18, 2024 •
edited
Loading

Already fixed. Sorry for late reply

@JamesoSAMP
Copy link

why is this not included into the latest release? The Bug is still there

@AmyrAhmady
Copy link
Collaborator

Because it's not merged yet? How can it be in latest release when it's not merged yet?

@JamesoSAMP
Copy link

Sorry, i am using Github for not so long, is there any way to faster the process this is some months behind :/

@AmyrAhmady
Copy link
Collaborator

You can use the older version for now if it's that important
Current code in this pull request is not exactly the most efficient one and requires some changes so it's not going into main project yet

@Tiaansu
Copy link
Contributor Author

Tiaansu commented Jan 27, 2025

Hi, can you tell me what is needed to change so it is efficient?

@Tiaansu
Copy link
Contributor Author

Tiaansu commented Feb 7, 2025

I think this should do the job. I remove other checks and moved it in the creation of pickups and actors.

@AmyrAhmady AmyrAhmady merged commit 707a471 into samp-incognito:master Feb 7, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmyrAhmady AmyrAhmady AmyrAhmady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tiaansu @AmyrAhmady @JamesoSAMP