Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn into a web component #344

Open
lastmjs opened this issue Aug 24, 2016 · 8 comments
Open

Turn into a web component #344

lastmjs opened this issue Aug 24, 2016 · 8 comments
Assignees
Labels

Comments

@lastmjs
Copy link

lastmjs commented Aug 24, 2016

It would be great if the library were turned into a web component. That would encapsulate and simplify initialization, and would work across all frameworks and browsers that support the web components standards or polyfills.

@sampotts
Copy link
Owner

I'd have to look into this in more detail as I've not done a lot with components yet (but would like to) 👍

@sampotts sampotts self-assigned this Aug 25, 2016
@jarryd999
Copy link

I want to resurface this as components have grown in the last two years. +1.

@sampotts
Copy link
Owner

I've actually been thinking about this a lot. Would there be an easy way for people to polyfill support for web components? How about Stencil ?

@lastmjs
Copy link
Author

lastmjs commented Oct 23, 2019

I believe all of the evergreen browsers support the standards now. Really custom elements are the most important piece, and there are lightweight polyfills for that API. I recommend looking into LitElement or just lit-html plus custom elements as a very lightweight solution to this problem

@jarryd999
Copy link

@lastmjs Can you share a link. I'm using lit-element and trying to fit this into my component but can't work out the issues.

@lastmjs
Copy link
Author

lastmjs commented Oct 23, 2019

Sorry, what would you like a link to?

@jarryd999
Copy link

jarryd999 commented Oct 23, 2019

I thought you had some solution to bring this into a LitElement component. If that is the case, I would like a link to that. If not, could you expand upon what you meant in that first comment of yesterday?

In particular, you recommended looking into LitElement as a lightweight solution to "this problem", which I took to mean using plyr in a component. I am using LitElement, but cannot figure out how to get plyr working in a component within the framework.

@lastmjs
Copy link
Author

lastmjs commented Oct 23, 2019

Oh I see. No, I do not have a solution for using plyr in a web component. I actually don't use this project anymore, I'm just trying to give some advice. The original issue was to encourage plyr itself to be a web component. I was encouraging the maintainers to implement plyr with LitElement or lit-html, which would hopefully make using plyr within your own web component or other applications simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants