Implementing support for Wistia?

[frumbert]

What's the best way to extend the player to support other api-enabled video sources such as Wistia?

[samhibberd]

@frumbert any luck with this?

[sampotts]

I want to make a plugin/module style framework, much like video JS etc. This way people can build their own. I'm not sure when I can start on it though.

[shornuk]

+1 for this!

[samhibberd]

Has any progress been made with this, Wistia is the only thing we need to make the switch, we would love to switch!

[sampotts]

I can't guarantee it'll happen any time soon. I'm a one man band and I'm having a little baby boy in 6 weeks. I'm still trying to finish other features then I'd need to build the framework I mentioned before.

[samhibberd]

Congratulations! Not to worry, i'm tempted to migrate our YouTube & Vimeo content anyway as plyr is beautiful!

[alejandroiglesias]

@sampotts congratulations! I'm also to have a little boy in about 12 weeks.

Do you need any help with this feature? Can you walk me a bit through the code in order to attempt it? Thanks and best wishes.

[samhibberd]

@sampotts @alejandroiglesias I have integrated it already. Been meaning to post it up for a while. Will do it today. Been running on a production site beautifully for a few months now.

[sampotts]

Awesome. If you're doing a PR, can you do it against the develop branch as otherwise I'll have a mammoth merge.

[alejandroiglesias]

@samhibberd great! 😃

[samhibberd]

@sampotts looks like there has been a whole load of changes in the develop branch since my work. I have pushed my changes up here: https://github.com/fruitstudios/plyr/commit/e21864e928f3de947067563c2a6af15facb31969
I can do a PR or just send you my work, let me what you would prefer? Want to avoid any mammoth merges :)

[alejandroiglesias]

Hey @samhibberd @sampotts, any progress on this?

[sampotts]

Not yet. I'm currently working on other features. I will get to this after. Also need to fix bugs first. Sam

…

On 21 Apr 2017, at 4:35 am, Alejandro García Iglesias ***@***.***> wrote: Hey @samhibberd @sampotts, any progress on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[alejandroiglesias]

@sampotts @samhibberd I opened a PR (#570) for Wistia support. Even though it looks code-complete, I can only hear the audio from the video, but no image (black image). Do you have any hints? Is it possible for you to take a look/test it so that we can debug that and complete the PR?
Thanks.

[samhibberd]

Sounds familiar, I think css related, you need to add / remove some wistia specific stuff in there. If you look over my code you will see what I did.

[alejandroiglesias]

@samhibberd thanks for chiming in. I looked at your commit and copied a couple of lines for the JS file, but overall it's hard to tell what is related to Wistia and what is related to upgrading Plyr from 2.0.10 to 2.0.11. Can you please point specifically something for me to look into?

[otraore]

Hey, are there any updates on this?

[dswitzer]

Progress on this seems to be halted, but I know these feature would be of use to us.

[alejandroiglesias]

@dswitzer see this.