Wistia support #570
Closed
Wistia support #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have to manually merge this one as it should have been against the develop branch as I said in the thread. |
|
@sampotts don't worry. Let me reopen a new PR against |
|
Awesome thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sampotts I opened this PR that implements support for Wistia. Even though to my understanding it looks code-complete, I can only hear the sound but no video image (black image). Do you have any hint on this so that we can finish this PR?
Also, please notice that there are 2 commits on this PR, one with the actual code changes to the lib, and another one with doc changes to reflect Wistia support.
Thanks.
Link to related issue (if applicable)
#393
Sumary of proposed changes
Implements support for Wistia video embeds.
Task list